Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored hook handlers in mod_stream_management #3884

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Refactored hook handlers in mod_stream_management #3884

merged 1 commit into from
Dec 1, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_stream_management module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 1, 2022 •
edited
Loading

small_tests_24 / small_tests / 3c9914e
Reports root / small

small_tests_25 / small_tests / 3c9914e
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 3c9914e
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3c9914e
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3c9914e
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 3c9914e
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 3c9914e
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 3c9914e
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3c9914e
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 3c9914e
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 676 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3c9914e
Reports root/ big
OK: 2664 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 3c9914e
Reports root/ big
OK: 2505 / Failed: 0 / User-skipped: 651 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 3c9914e
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 3c9914e
Reports root/ big
OK: 4478 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 3c9914e
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Base: 81.63% // Head: 83.15% // Increases project coverage by +1.52% 🎉

Coverage data is based on head (c3404c3) compared to base (2affe7e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3884      +/-   ##
==========================================
+ Coverage   81.63%   83.15%   +1.52%     
==========================================
  Files         535      535              
  Lines       34205    34204       -1     
==========================================
+ Hits        27923    28444     +521     
+ Misses       6282     5760     -522
Impacted Files Coverage Δ
src/ejabberd_hooks.erl 61.53% <ø> (-30.77%) ⬇️
src/stream_management/mod_stream_management.erl 92.15% <100.00%> (-0.16%) ⬇️
src/async_pools/mongoose_aggregator_worker.erl 63.33% <0.00%> (-5.01%) ⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/auth/ejabberd_auth.erl 83.24% <0.00%> (-1.53%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/ejabberd_c2s.erl 89.32% <0.00%> (+0.37%) ⬆️
src/mod_roster.erl 79.27% <0.00%> (+0.48%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 1, 2022 •
edited
Loading

small_tests_24 / small_tests / c3404c3
Reports root / small

small_tests_25 / small_tests / c3404c3
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c3404c3
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / c3404c3
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c3404c3
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c3404c3
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c3404c3
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c3404c3
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 676 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c3404c3
Reports root/ big
OK: 2664 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c3404c3
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c3404c3
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / c3404c3
Reports root/ big
OK: 2505 / Failed: 0 / User-skipped: 651 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c3404c3
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c3404c3
Reports root/ big
OK: 4478 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c3404c3
Reports root/ big
OK: 4503 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2693@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2693@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"y4cACT1ypkdB7wz4JCZu+g==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@pawlooss1 pawlooss1 marked this pull request as ready for review December 1, 2022 11:06
NelsonVides
NelsonVides approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides NelsonVides merged commit b28a1cf into master Dec 1, 2022
@NelsonVides NelsonVides deleted the hooks/mod_stream_management branch December 1, 2022 11:19
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

@kamilwaz kamilwaz Awaiting requested review from kamilwaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pawlooss1 @mongoose-im @NelsonVides @chrzaszcz